Correct columns returned in synonym functions, update NEWS #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rachmaninoffpk
left a comment
rachmaninoffpk
left a comment
There was a problem hiding this comment.
The functions are operating as expected with the column changes. The tests are failing. I will re-record the responses and see if that resolves the failed test.
Collaborator
|
It looks like the duplicate entries may be on the server side rather than the client side. |
rachmaninoffpk
approved these changes
Dec 16, 2025
Collaborator
Author
|
Agree that it may be an API server-side issue. Created this ticket in the Chemical API repo: USEPA/ccte-api-chemical#312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The individual function seems to work, but the batch function appears to be returning duplicate rows. Thoughts?
dtxsid <- c('DTXSID7020182', 'DTXSID2021315', 'DTXSID9020112')
batch_synonyms <- get_chemical_synonym_batch(DTXSID = dtxsid)