Lex Pages Data Handlers #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davenquinn
reviewed
Jun 7, 2025
Member
davenquinn
left a comment
davenquinn
left a comment
There was a problem hiding this comment.
Looks like a decent start but you need to update the `IndividualPage' function to be a proper React component.
Also it's worth noting that server-side loading won't be fully achieved until you switch Pages from +Page.client.ts to +Page.ts. This may require making the map and other page elements load lazily – see the columns page for how to do this.
pages/lex/index.ts
Outdated
| if (type === "concept_id") { | ||
| type = "strat_name_concept_id"; | ||
| } | ||
| export function IndividualPage(id, header, res, fossilRes, colData, taxaData) { |
Member
There was a problem hiding this comment.
This has some architectural challenges:
- The
IndividualPageshould be a React component but it is not. Make all of the arguments into props instead, and create a Typescript type to guide the user on what the props should be. Having this as a function that returns React elements based on arguments is a sketchy design IndividualPageis not a very descriptive name- This is a subsidiary problem, at least for now, but this component suffers from a little bit of bloat in trying to create a "one size fits all" approach to rendering a lexicon page
Member
Author
There was a problem hiding this comment.
First two points fixed in new commits
Member
Author
|
All page.client.ts pages changes to regular page.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
lexiconmain pages and individual pages use a+data.tshandler to allow for better web search crawlabilityAlso, fixing linking issue with new
strat-namespage