Autonomy Phase 2 (files labelled and linters fixed)#46
Closed
christghuynh wants to merge 11 commits intoUWARG:mainfrom
Closed
Autonomy Phase 2 (files labelled and linters fixed)#46christghuynh wants to merge 11 commits intoUWARG:mainfrom
christghuynh wants to merge 11 commits intoUWARG:mainfrom
Conversation
ellyokes253
reviewed
Feb 6, 2026
logs/telemetry/main.log
Outdated
| @@ -0,0 +1,2 @@ | |||
| 14:50:51: [INFO] [C:\Users\chris\warg-autonomy-bootcamp\autonomy-bootcamp-2025-p2\modules\common\modules\logger\logger_main_setup.py | setup_main_logger | 62] main logger initialized | |||
Contributor
There was a problem hiding this comment.
either in your main or worker logs you need to log the telemetry data object
ellyokes253
reviewed
Feb 6, 2026
logs/heartbeat_receiver/main.log
Outdated
| @@ -0,0 +1,2 @@ | |||
| 14:49:48: [INFO] [C:\Users\chris\warg-autonomy-bootcamp\autonomy-bootcamp-2025-p2\modules\common\modules\logger\logger_main_setup.py | setup_main_logger | 62] main logger initialized | |||
Contributor
There was a problem hiding this comment.
you need to log either "disconnected" or "connected" as the status
ellyokes253
reviewed
Feb 6, 2026
| self, | ||
| args, # Put your own arguments here | ||
| ): | ||
| def run(self: "HeartbeatSender") -> tuple[bool, None]: |
Contributor
There was a problem hiding this comment.
you don't have to return a tuple if you don't need to
ellyokes253
reviewed
Feb 6, 2026
bootcamp_main.py
Outdated
| if status == "Disconnected": | ||
| break | ||
| main_logger.info(f"Heartbeat Status: {status}") | ||
| while not command_to_main_queue.queue.empty(): |
Contributor
There was a problem hiding this comment.
this shouldn't be in a while loop
Contributor
|
reviewed! |
ellyokes253
reviewed
Feb 8, 2026
bootcamp_main.py
Outdated
Comment on lines
237
to
240
| if not telemetry_to_command_queue.queue.empty(): | ||
| telemetry_data = telemetry_to_command_queue.queue.get_nowait() | ||
| main_logger.info(f"Telemetry data: {telemetry_data}") | ||
| telemetry_to_command_queue.queue.put(telemetry_data) |
Contributor
There was a problem hiding this comment.
you only need to check the command_to_main_queue since the telemetry_to_command_queue empties into there anyways
Contributor
|
reviewed! |
Contributor
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.