Open
Conversation
upadhyaydhruv
approved these changes
Jan 30, 2022
|
|
||
| const int SERVO_MIN_MS = 900; | ||
| const int SERVO_MAX_MS = 2000; | ||
| const int SERVO_MIN_MS = 400; |
There was a problem hiding this comment.
Was this required because the servos being used are different from last time?
Author
There was a problem hiding this comment.
I have no idea about last time, I tested it on the servos today and it didn't have the full range of motion with those min and max values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated some code and the readme for the gimbal test. Tested onsite.