Skip to content

Recorder Updates for Neuro and NG911 #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: SharedDevelopment
Choose a base branch
from

Conversation

zshaikh5
Copy link
Contributor

Closes #722
Closes #719
Closes #574

Description

This expands the set of variables recorded by including additional ones, providing a wider range of the data captured. Additionally, it removes the dependency on XML911Recorder by using the recorders instead.

Checklist (Mandatory for new features)

  • Added Documentation
  • Added Unit Tests

Testing (Mandatory for all changes)

  • GPU Test: test-medium-connected.xml Passed
  • GPU Test: test-large-long.xml Passed

@zshaikh5 zshaikh5 requested a review from stiber March 24, 2025 11:45
Copy link
Contributor

@stiber stiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can merge this, we need to manually check the various new GoodOutput files against the contents of the same files in SharedDevelopment. @stiber will lead that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants