Prishpat — Backend Onboarding#19
Closed
prishpat19 wants to merge 2 commits intoUWOrbital:mainfrom
prishpat19:main
Closed
Prishpat — Backend Onboarding#19prishpat19 wants to merge 2 commits intoUWOrbital:mainfrom prishpat19:main
prishpat19 wants to merge 2 commits intoUWOrbital:mainfrom
prishpat19:main
Conversation
Yarik-Popov
reviewed
May 6, 2025
| """ | ||
| # TODO:(Member) Implement this endpoint | ||
| command = db.get(Command, id) | ||
| if not command: |
Contributor
There was a problem hiding this comment.
Use command is None here
Yarik-Popov
reviewed
May 6, 2025
| @@ -1,8 +1,12 @@ | |||
| import time | |||
Contributor
There was a problem hiding this comment.
Import what you need from the module as this follows our import convention.
Yarik-Popov
reviewed
May 6, 2025
Comment on lines
8
to
9
| import logging | ||
| custom_logger = logging.getLogger("my_logger") |
Yarik-Popov
reviewed
May 6, 2025
Yarik-Popov
requested changes
May 6, 2025
Contributor
Yarik-Popov
left a comment
Yarik-Popov
left a comment
There was a problem hiding this comment.
Overall good start to the backend onboarding. Some changes are needed to improve it
| @return Response from endpoint | ||
| """ | ||
| # TODO:(Member) Finish implementing this method | ||
| start_time = time.time() |
Contributor
There was a problem hiding this comment.
Minor you should use perf_counter here instead
| custom_logger.info(f"Query Params: {dict(request.query_params)}") | ||
|
|
||
| # Process request | ||
| response = await call_next(request) |
Contributor
There was a problem hiding this comment.
Print the response body as well
backend/data/data_models.py
Outdated
| ) | ||
|
|
||
|
|
||
| raise ValueError("Both 'params' and 'format' must be None or must have the same number of comma-separated values.") |
Contributor
There was a problem hiding this comment.
Print the params and format values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.