Conversation
Yarik-Popov
requested changes
May 9, 2025
Contributor
Yarik-Popov
left a comment
Yarik-Popov
left a comment
There was a problem hiding this comment.
Should be last set of changes
backend/data/data_models.py
Outdated
| if self.params is None and self.format is None: | ||
| return self | ||
| if self.params is None or self.format is None: | ||
| print(f"[Validation Error] params: {self.params}, format: {self.format}") |
Contributor
There was a problem hiding this comment.
Since we are raising an exception we shouldnt be printing. Same thing below
| custom_logger.info(f"Query Params: {dict(request.query_params)}") | ||
|
|
||
|
|
||
| response = await call_next(request) |
Contributor
There was a problem hiding this comment.
Print the response body as well for completeness
Contributor
|
Congrats on finishing the GS backend on boarding. DM me your email and I'll add you to the notion (we only use it for the wiki and meeting minutes). I'll add u to the github org in a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the GS on-boarding task. Include a screenshot of the front-end of the application.
New Changes
Testing
Outstanding Changes