Kai ZHang GS-Onboarding

[Scr4tch587]

Purpose

Completed the GS on-boarding task. Include a screenshot of the front-end of the application.

• I have added my name to the onboarding title (required)
• I have added a screenshot of the logs printed by the logger middleware (required)
• I am interested to work on the frontend (optional)

New Changes

Backend

• Added data validation for command requests
• Added a post endpoint for commands, allowing for them to be added to the database
• Added a delete endpoint for commands, allowing for them to be removed from the database
• Added a logger middleware
  Frontend
• Added the functionality to delete commands and linked it to the delete endpoint of the backend using Axios
• Created a selection form to allow users to create new commands based on MainCommands

Testing

• Explain tests that you ran to verify code functionality.
• Passed all pytests

- Checked the state of the gs_python.log printed by the logger middleware - Locally ran the frontend and tested the functionality of adding/deleting commands

[Adityya-K]

I have reviewed the backend, another lead will review the front end! Great first push, just some changes with error logging, unnecessary overhead and reused functionality

[Adityya-K]

This seems like repeated functionality, you can use the get_commands() function here!

[Adityya-K]

We shouldn't be calling these functions on every dispatch since we are just starting and opening the logger over and over again which is unnecessary overhead.

[Adityya-K]

Try making these ValueError more descriptive by adding a message string within brackets ValueError("Something went wrong") (of course, make the message descriptive)

[Adityya-K]

LGTM! Not closing, in case the frontend is reviewed.