Pei Lin He - completed onboarding (backend)#44
Open
cryolins wants to merge 6 commits intoUWOrbital:mainfrom
Open
Pei Lin He - completed onboarding (backend)#44cryolins wants to merge 6 commits intoUWOrbital:mainfrom
cryolins wants to merge 6 commits intoUWOrbital:mainfrom
Conversation
Adityya-K
reviewed
Sep 20, 2025
Adityya-K
left a comment
Adityya-K
left a comment
There was a problem hiding this comment.
Great first push! Just two things to fix and you will be onboarded!
backend/api/endpoints/command.py
Outdated
| db.delete(item) | ||
| db.commit() | ||
|
|
||
| items = db.exec(select(Command)).all() |
There was a problem hiding this comment.
This seems to be repeated functionality! You can use the get_commands() function here instead!
backend/data/data_models.py
Outdated
| return self | ||
| if(self.params is None or self.format is None | ||
| or self.params.count(",") != self.format.count(",")): | ||
| raise ValueError() |
There was a problem hiding this comment.
Can you make this value error have a description (i.e. ValueError("Description here"))
Author
|
okay, and here's a frontend pic just in case it's needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the GS on-boarding task. Include a screenshot of the front-end of the application.
New Changes
Testing