Closed
Conversation
Adityya-K
reviewed
Oct 24, 2025
Adityya-K
left a comment
There was a problem hiding this comment.
Well done! This LGTM! Just make sure to no commit unnecessary files when pushing to the actual codebase
Author
Thanks! Sure I might have accidently run npm i and staged all files and commited :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
New Changes
Completed
validate_params_formatmethod inbackend/data/data_models.py)create_commandfunction inbackend/api/endpoints/command.py)delete_commandfunction inbackend/api/endpoints/command.py)backend/api/middlewares/logger_middleware.py)Testing
Through the 13tests being written with pytest already.