Shawn Li Complete backend onboarding tasks#67
Closed
Shawn1i wants to merge 2 commits intoUWOrbital:mainfrom
Closed
Shawn Li Complete backend onboarding tasks#67Shawn1i wants to merge 2 commits intoUWOrbital:mainfrom
Shawn1i wants to merge 2 commits intoUWOrbital:mainfrom
Conversation
Syzygicality
requested changes
Jan 14, 2026
Syzygicality
left a comment
Syzygicality
left a comment
There was a problem hiding this comment.
If you are still interested in joining the team, please fulfill these change requests :)
| """ | ||
| # TODO:(Member) Finish implementing this method | ||
|
|
||
| start_time = time.time() |
There was a problem hiding this comment.
please include screenshot of the logs printed. This can be done by running the API, and querying the GET endpoint on the /docs page.
backend/data/data_models.py
Outdated
| The format of the comma seperated values is "data1,data2" so no spaces between data and the commas. | ||
| """ | ||
| # TODO: (Member) Implement this method | ||
| if self.params is None and self.format is None: |
There was a problem hiding this comment.
Note that None type is "falsy" in python, so the conditionals can be refactored
proprogrammer504
left a comment
proprogrammer504
left a comment
There was a problem hiding this comment.
looks mostly good to me, just a single thing!
|
|
||
| response = await call_next(request) | ||
|
|
||
| duration = time.time() - start_time |
There was a problem hiding this comment.
any way to print these in ms?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the GS on-boarding task. Include a screenshot of the front-end of the application.
New Changes
Testing