Jonathan Zhang - Ground Station onboarding#69
Open
JonathanmZhang wants to merge 3 commits intoUWOrbital:mainfrom
Open
Jonathan Zhang - Ground Station onboarding#69JonathanmZhang wants to merge 3 commits intoUWOrbital:mainfrom
JonathanmZhang wants to merge 3 commits intoUWOrbital:mainfrom
Conversation
proprogrammer504
requested changes
Jan 9, 2026
proprogrammer504
left a comment
proprogrammer504
left a comment
There was a problem hiding this comment.
Looks good overall! Just a few very minor changes.
| request_time = to_unix_time(datetime.datetime.now()) | ||
|
|
||
| response: Response = await call_next(request) | ||
| duration = time.perf_counter() - start |
There was a problem hiding this comment.
Minor thing, any way to convert this into ms?
backend/data/data_models.py
Outdated
| if (self.params != None and self.format != None) and len(self.params.split(",")) == len(self.format.split(",")): | ||
| return self | ||
| else: | ||
| raise ValueError("Value error") |
There was a problem hiding this comment.
Could you add a more descriptive error message?
backend/api/endpoints/command.py
Outdated
|
|
||
| command = db.exec(select(Command).where(Command.id == id)).one_or_none() | ||
| if command is None: | ||
| raise HTTPException(status_code=404, detail="Error") |
There was a problem hiding this comment.
A more detailed error message would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the GS on-boarding task. Include a screenshot of the front-end of the application.
New Changes
Testing