Complete command endpoints, validation, and logger middleware - Shaurya Likhi#70
Closed
Shaurya1126 wants to merge 2 commits intoUWOrbital:mainfrom
Closed
Complete command endpoints, validation, and logger middleware - Shaurya Likhi#70Shaurya1126 wants to merge 2 commits intoUWOrbital:mainfrom
Shaurya1126 wants to merge 2 commits intoUWOrbital:mainfrom
Conversation
Syzygicality
requested changes
Jan 15, 2026
Syzygicality
left a comment
Syzygicality
left a comment
There was a problem hiding this comment.
looks fine overall, just a few comments and change requests :)
| except Exception as e: | ||
| # Ensure errors are logged if the endpoint crashes | ||
| logger.error(f"Request Failed | {method} {url} | Error: {str(e)}") | ||
| raise e |
There was a problem hiding this comment.
could you raise an HTTPException formatted with e instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the GS on-boarding task (primarily the backend).