Closed
Conversation
proprogrammer504
requested changes
Jan 22, 2026
proprogrammer504
left a comment
proprogrammer504
left a comment
There was a problem hiding this comment.
reviewed, just have one small change which id like, detailed in the comments.
| # TODO: (Member) Implement this method | ||
| return self | ||
|
|
||
| # Copy params and format |
There was a problem hiding this comment.
this looks good, but make sure to throw and return a value error on failure cases.
Author
There was a problem hiding this comment.
I think I added it now :D
proprogrammer504
requested changes
Jan 22, 2026
backend/data/data_models.py
Outdated
| if (lenParams == lenFormat): | ||
| return self | ||
| else: | ||
| raise ValueError |
There was a problem hiding this comment.
nice, but more detail on what failed would be nice.
Member
|
nice job, approved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the GS on-boarding task. Include a screenshot of the front-end of the application.
New Changes
Testing
Pytests:
Middleware Logging:
