Complete backend onboarding challenge(Tony Zheng): command endpoints, models, and logging#74
Closed
tonyZh-7075 wants to merge 2 commits intoUWOrbital:mainfrom
Closed
Complete backend onboarding challenge(Tony Zheng): command endpoints, models, and logging#74tonyZh-7075 wants to merge 2 commits intoUWOrbital:mainfrom
tonyZh-7075 wants to merge 2 commits intoUWOrbital:mainfrom
Conversation
Syzygicality
requested changes
Jan 28, 2026
| logger.error(f"Request failed: {request.method} {request.url} | Error: {e}") | ||
| raise | ||
|
|
||
| duration = (datetime.now() - start_time).total_seconds() |
There was a problem hiding this comment.
set to milliseconds instead of seconds for clarity
backend/data/data_models.py
Outdated
| # TODO: (Member) Implement this method | ||
|
|
||
| # valid if both are none | ||
| if self.params is None and self.format is None: |
There was a problem hiding this comment.
Note that None type is "falsy" in python, so None comparison is not necessary
Author
There was a problem hiding this comment.
thanks for pointing this out. i've fixed it, thanks!
backend/api/endpoints/command.py
Outdated
| # TODO:(Member) Implement this endpoint | ||
|
|
||
|
|
||
| main_command = db.get(MainCommand, payload.command_type) |
There was a problem hiding this comment.
since you are creating a command, its unnecessary to check whether it exists.
Author
|
All requested changes have been addressed. Marking this as ready for re-review — thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Completed the required GS backend onboarding tasks
New changes:
Testing
/docsand/commandsendpoints