Skip to content

Change navbar links in MCC#324

Merged
Jiatao7 merged 2 commits intomainfrom
jiatao/change-navbar-links
Mar 8, 2025
Merged

Change navbar links in MCC#324
Jiatao7 merged 2 commits intomainfrom
jiatao/change-navbar-links

Conversation

@Jiatao7
Copy link
Contributor

@Jiatao7 Jiatao7 commented Mar 6, 2025

Purpose

To change the navbar links in the MCC to be consistent with the ARO. Notion task: https://www.notion.so/uworbital/Change-the-Navbar-links-in-MCC-1908a26d767780af950cde20585f8ae0

image.png

New Changes

  • Changed navbar links in the MCC to use react-router
  • Changed the navbar design to make it match the ARO (added the UW Orbital logo on the left and made the navbar background black)

Testing

  • Tested it locally

Outstanding Changes

  • Generalize the navbar into a separate directory

@Jiatao7 Jiatao7 requested a review from Yarik-Popov March 6, 2025 23:59
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
kepler452b123 21 2d 10h 56m 89
Yarik-Popov 11 1d 6h 56m 104
dgobalak 1 6d 4h 55m 7
Navtajh04 1 1d 7h 36m 2

⚡️ Pull request stats

Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Honestly minor changes just to make it easier to generalize this later if we want to.

@Jiatao7 Jiatao7 requested a review from Yarik-Popov March 7, 2025 02:02
Copy link
Contributor

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Jiatao7 Jiatao7 merged commit 4cdfda0 into main Mar 8, 2025
48 checks passed
@Jiatao7 Jiatao7 deleted the jiatao/change-navbar-links branch March 8, 2025 01:33
@Yarik-Popov Yarik-Popov added this to the 25W milestone Mar 9, 2025
@Yarik-Popov Yarik-Popov added the project: frontend Frontend tasks label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: frontend Frontend tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants