Conversation
Yarik-Popov
requested changes
Mar 9, 2025
Contributor
Yarik-Popov
left a comment
There was a problem hiding this comment.
Overall quite good. Some changes are needed
Contributor
|
Thanks for adding screenshots. Can you also include the endpoint code so i can play around with it? |
7 tasks
Yarik-Popov
requested changes
Mar 12, 2025
Closed
9 tasks
Yarik-Popov
requested changes
Mar 14, 2025
Yarik-Popov
previously requested changes
Mar 17, 2025
Contributor
There was a problem hiding this comment.
Overall quite good. Some minor changes are left.
One thing you should add is an request id that's automatically generated for each request that is a uuid so we can easily associate request and response pairs. Print this id in both the request/response logging
Yarik-Popov
approved these changes
Mar 20, 2025
Contributor
Yarik-Popov
left a comment
There was a problem hiding this comment.
LGTM, the effort of unit testing this is quite large for a very small benefit. We will only need this for debugging and monitoring purposes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #369
New Changes
Testing
running the endpoint /api/v1/mcc/commands/double?data=hello world! should return {"data": "hello world! hello world!"}
Normal:

Error:

Critical Error:

Outstanding Changes