Skip to content

Modify command policy handling#374

Merged
jordynmindorff merged 1 commit intomainfrom
jordyn/command-policy
Mar 19, 2025
Merged

Modify command policy handling#374
jordynmindorff merged 1 commit intomainfrom
jordyn/command-policy

Conversation

@jordynmindorff
Copy link
Contributor

Purpose

Basically just makes a minor change to how command policies are assigned/work.
Task: https://uworbital.notion.site/Modify-command-policy-handling-aa594df7180d4bc2bb22db11193551c5

New Changes

  • When creating commands you just set the command policy to the most restrictive policy you want. Rn all of our commands are available for PROD anyways. But PROD is now a subset of RND, so all PROD commands will work in RND.

Testing

  • Built and didn't break anything :)
  • Confirmed the OBC_ACTIVE_POLICY build flag works and is accessible in the code
  • I actually don't know how to formally test this because its part of a manager/task, so it's not like you can do unit tests. But the changes are pretty minor so...

Outstanding Changes

  • N/A

@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
kepler452b123 27 2d 4h 15m 94
Yarik-Popov 16 1d 2h 1m 142

⚡️ Pull request stats

@jordynmindorff jordynmindorff merged commit 29ed482 into main Mar 19, 2025
48 checks passed
@jordynmindorff jordynmindorff deleted the jordyn/command-policy branch March 19, 2025 19:56
@Yarik-Popov Yarik-Popov added this to the 25W milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants