Fix logger middleware causing 500 error if request has body workaround#392
Merged
Yarik-Popov merged 1 commit intomainfrom May 11, 2025
Conversation
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
kepler452b123
approved these changes
May 11, 2025
Yarik-Popov
deleted the
391-logger-middleware-causes-500-internal-server-if-request-has-body
branch
Yarik-Popov
added a commit
that referenced
this pull request
May 11, 2025
… 361-create-endpoints-for-aro-user * 'main' of https://github.com/UWOrbital/OBC-firmware: Fix logger middleware causing 500 error if request has body workaround (#392)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #391. This PR is intended to be a workaround to the issue. We still should be logging the request body, see the Outstanding Changes.
New Changes
Testing
361-create-endpoints-for-aro-userOutstanding Changes
call_nextline