Skip to content

Integrate gs building code for MacOS systems#552

Merged
c4bae merged 12 commits intomainfrom
charles/readme-for-ground-station-cli
Oct 1, 2025
Merged

Integrate gs building code for MacOS systems#552
c4bae merged 12 commits intomainfrom
charles/readme-for-ground-station-cli

Conversation

@c4bae
Copy link
Contributor

@c4bae c4bae commented Sep 19, 2025

Purpose

Previously, no instructions were provided on how to build the ground station program for MacOS systems. This PR adds steps on how to fix the errors that are encountered while building it.

New Changes

  • Instructions on building gs for MacOS systems were added to the readme

Testing

Explain tests that you ran to verify code functionality.

  • I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have tested this PR on a board if the code will run on a board (Only required for firmware developers).
  • I have tested this PR by running the ARO website (Only required if the code will impact the ARO website).
  • I have tested this PR by running the MCC website (Only required if the code will impact the MCC website).
  • I have included screenshots of the tests performed below.

Outstanding Changes

If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

  • Currently, the instructions allow for successfully launching the cli. More thorough testing may be required for full functionality

@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
Adityya-K 22 20h 4m 94
kepler452b123 14 6d 7h 42m 52
Yarik-Popov 9 1d 4h 42m 68
camspec 7 1d 4h 44m 51
Navtajh04 7 5d 1h 23m 73
altrup 1 1d 3h 52m 1

⚡️ Pull request stats

@c4bae c4bae force-pushed the charles/readme-for-ground-station-cli branch from 3876116 to bb9a473 Compare September 19, 2025 22:39
@Adityya-K
Copy link
Contributor

Since this involves modifying a CMakeLists.txt file could you just add the modifications (by conditionally detecting for mac) and then we can just make it a part of our build system!

@c4bae c4bae changed the title Add gs building instructions for MacOS systems Integrate gs building code for MacOS systems Sep 26, 2025
Copy link
Contributor

@Adityya-K Adityya-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c4bae c4bae merged commit dcb6423 into main Oct 1, 2025
49 checks passed
@c4bae c4bae deleted the charles/readme-for-ground-station-cli branch October 1, 2025 02:53
c4bae added a commit that referenced this pull request Oct 1, 2025
# Purpose
Previously, no instructions were provided on how to build the ground
station program for MacOS systems. This PR adds steps on how to fix the
errors that are encountered while building it.

# New Changes
- Instructions on building gs for MacOS systems were added to the readme

# Testing
Explain tests that you ran to verify code functionality.
- [x] I have unit-tested this PR. Otherwise, explain why it cannot be
unit-tested.
- [ ] I have tested this PR on a board if the code will run on a board
(Only required for firmware developers).
- [ ] I have tested this PR by running the ARO website (Only required if
the code will impact the ARO website).
- [ ] I have tested this PR by running the MCC website (Only required if
the code will impact the MCC website).
- [ ] I have included screenshots of the tests performed below.

# Outstanding Changes
If there are non-critical changes (i.e. additional features) that can be
made to this feature in the future, indicate them here.
- Currently, the instructions allow for successfully launching the cli.
More thorough testing may be required for full functionality

# Purpose
Closes #ISSUE_NUMBER.
Explain the purpose of the PR here if it doesn't match the linked issue.
Be sure to add a comment in the linked issue explaining the changes.

# New Changes
Explain new changes below in short bullet points.

# Testing
Explain tests that you ran to verify code functionality.
- [ ] I have unit-tested this PR. Otherwise, explain why it cannot be
unit-tested.
- [ ] I have tested this PR on a board if the code will run on a board
(Only required for firmware developers).
- [ ] I have tested this PR by running the ARO website (Only required if
the code will impact the ARO website).
- [ ] I have tested this PR by running the MCC website (Only required if
the code will impact the MCC website).
- [ ] I have included screenshots of the tests performed below.

# Outstanding Changes
If there are non-critical changes (i.e. additional features) that can be
made to this feature in the future, indicate them here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants