Skip to content

Conversation

@jess-tech-lab
Copy link
Contributor

Purpose

Closes #361

New Changes

  • Implemented user endpoint for GET/PUT/POST

Testing

Explain tests that you ran to verify code functionality.

  • I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have tested this PR on a board if the code will run on a board (Only required for firmware developers).
  • I have tested this PR by running the ARO website (Only required if the code will impact the ARO website).
  • I have tested this PR by running the MCC website (Only required if the code will impact the MCC website).
  • I have included screenshots of the tests performed below.

Outstanding Changes

If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

Copy link
Contributor

@Adityya-K Adityya-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently we got data_wrappers implemented which are just a library of functions that implement most of the functionality you are implementing in your API functions. They should be in a data_wrappers directory, so try using those instead of repeating the logic! (Just message me on discord if you need clarification)

Also make sure pre-commit is setup and that your PR passes the CI/CD tests on github (the tests that show near the merge button)

@jess-tech-lab
Copy link
Contributor Author

Superseded by #562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create endpoints for ARO user

2 participants