Skip to content

Conversation

@GitWorkingTime
Copy link

@GitWorkingTime GitWorkingTime commented Sep 24, 2025

Purpose

Closes #502
Explain the purpose of the PR here if it doesn't match the linked issue. Be sure to add a comment in the linked issue explaining the changes.

  • Update the safety-critical command handling using an ARM & EXECUTE design to prevent false triggers caused by operator mistakes

New Changes

Explain new changes below in short bullet points.

  • Added CMD_ARM skeleton to the codebase
  • Added CMD_EXECUTE skeleton to the codebase
  • Added command response to both CMD_ARM and CMD_EXECUTE
  • Waiting on Software Leads to give more info on the command's functionality

Testing

Explain tests that you ran to verify code functionality.

  • I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have tested this PR on a board if the code will run on a board (Only required for firmware developers).
  • I have tested this PR by running the ARO website (Only required if the code will impact the ARO website).
  • I have tested this PR by running the MCC website (Only required if the code will impact the MCC website).
  • I have included screenshots of the tests performed below.

Outstanding Changes

If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
Adityya-K 24 20h 4m 92
kepler452b123 17 4d 1h 1m 74
camspec 10 17h 17m 68
Yarik-Popov 8 1d 4h 42m 65
Navtajh04 6 5d 1h 23m 68

⚡️ Pull request stats

Copy link
Contributor

@Adityya-K Adityya-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really well done first commit! Just make sure to fix the CI/CD tests before you request a review since we usually want those passing before we merge anything into our main branch. I have only skimmed the PR right now but I will give it a closer look and update the instructions for what you need to do with these two commands!

@GitWorkingTime
Copy link
Author

All checks have passed, now just waiting for further instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement safety-critical command handling

2 participants