implement revamped textual-gs-cli #597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Purpose Previously, no instructions were provided on how to build the ground station program for MacOS systems. This PR adds steps on how to fix the errors that are encountered while building it. # New Changes - Instructions on building gs for MacOS systems were added to the readme # Testing Explain tests that you ran to verify code functionality. - [x] I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested. - [ ] I have tested this PR on a board if the code will run on a board (Only required for firmware developers). - [ ] I have tested this PR by running the ARO website (Only required if the code will impact the ARO website). - [ ] I have tested this PR by running the MCC website (Only required if the code will impact the MCC website). - [ ] I have included screenshots of the tests performed below. # Outstanding Changes If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here. - Currently, the instructions allow for successfully launching the cli. More thorough testing may be required for full functionality # Purpose Closes #ISSUE_NUMBER. Explain the purpose of the PR here if it doesn't match the linked issue. Be sure to add a comment in the linked issue explaining the changes. # New Changes Explain new changes below in short bullet points. # Testing Explain tests that you ran to verify code functionality. - [ ] I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested. - [ ] I have tested this PR on a board if the code will run on a board (Only required for firmware developers). - [ ] I have tested this PR by running the ARO website (Only required if the code will impact the ARO website). - [ ] I have tested this PR by running the MCC website (Only required if the code will impact the MCC website). - [ ] I have included screenshots of the tests performed below. # Outstanding Changes If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
…mware into charles/textual-gs-cli
camspec
requested changes
Nov 20, 2025
Member
camspec
left a comment
camspec
left a comment
There was a problem hiding this comment.
Lots of great revamping, but there are a few issues
| """ | ||
| Entry point for the CLI application, sets up serial and runs the app | ||
| """ | ||
| if len(argv) != 2: |
Member
There was a problem hiding this comment.
We never reach this point if the argument is missing since argv[1] is undefined
…mware into charles/textual-gs-cli
camspec
reviewed
Nov 23, 2025
Member
camspec
left a comment
camspec
left a comment
There was a problem hiding this comment.
looks good! make sure Adityya reviews this
gs/backend/cli.py
Outdated
| def main() -> None: | ||
| """ | ||
| Entry point for the CLI application, sets up serial and runs the app | ||
| Usage: Entry point for the CLI application; opens the serial port at the com port and runs the ground station cli. |
Member
There was a problem hiding this comment.
The Usage convention was referring to the error message when the arguments don't match. The original docstring was fine. Also, provide an exit code if there was a failure.
Adityya-K
requested changes
Jan 5, 2026
Contributor
Adityya-K
left a comment
Adityya-K
left a comment
There was a problem hiding this comment.
Code itself looks good and I see no glaring issues except for some minor things and the use of a lambda function I might be misunderstanding. Could you just move all the cli and ground_station_cli files into a separate folder named gs/backend/gs_cli.
Additionally this just needs to be tested and it should be good!
…mware into charles/textual-gs-cli
camspec
previously approved these changes
Feb 6, 2026
Member
camspec
left a comment
camspec
left a comment
There was a problem hiding this comment.
lgtm, one small thing that would be good to change (unrelated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #547, up until time tagged data functionality
New Changes
Testing
Explain tests that you ran to verify code functionality.
Outstanding Changes
If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.
Screenshots
OLD LAYOUT BUT DEMONSTRATION OF LOGS
CURRENT LAYOUT
