Skip to content

refactored wrappers to standardize UUID#598

Merged
Syzygicality merged 2 commits intomainfrom
eddie/wrapper-refactoring
Oct 29, 2025
Merged

refactored wrappers to standardize UUID#598
Syzygicality merged 2 commits intomainfrom
eddie/wrapper-refactoring

Conversation

@Syzygicality
Copy link
Contributor

@Syzygicality Syzygicality commented Oct 28, 2025

Purpose

Closes #ISSUE_NUMBER.
Explain the purpose of the PR here if it doesn't match the linked issue. Be sure to add a comment in the linked issue explaining the changes.

New Changes

Explain new changes below in short bullet points.

  • Previously, the object id passed in for delete and retrieve for all concrete wrappers either could be int or UUID.
  • However, the only tables that use int as primary key are the main table.
  • I set the abstract wrapper to take an unspecified type on the delete and retrieve methods.
  • I then specified the param type for those methods in MainCommandWrapper and MainTelemetryWrapper to only take int.

Testing

Explain tests that you ran to verify code functionality.

  • I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have tested this PR on a board if the code will run on a board (Only required for firmware developers).
  • I have tested this PR by running the ARO website (Only required if the code will impact the ARO website).
  • I have tested this PR by running the MCC website (Only required if the code will impact the MCC website).
  • I have included screenshots of the tests performed below.

Outstanding Changes

If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
Adityya-K
🥇
49
▀▀▀▀▀
1d 2h 39m
167
▀▀▀▀
camspec
🥈
19
▀▀
23h 54m
130
▀▀▀
kepler452b123
🥉
16
▀▀
6d 5h 35m
▀▀
48
Yarik-Popov
5
1d 3h 12m
41
Navtajh04
2
7d 12h 7m
▀▀
25
sunray4
1
12d 21m
▀▀▀
9
proprogrammer504
1
8d 6h 19m
▀▀
5

⚡️ Pull request stats

@Syzygicality Syzygicality requested a review from camspec October 29, 2025 00:23
@Syzygicality Syzygicality self-assigned this Oct 29, 2025
Copy link
Member

@camspec camspec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syzygicality Syzygicality merged commit 17b56b0 into main Oct 29, 2025
49 checks passed
@Syzygicality Syzygicality deleted the eddie/wrapper-refactoring branch October 29, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants