Retrieve floating commands and add abstract wrappers to conftest#600
Merged
proprogrammer504 merged 2 commits intomainfrom Nov 7, 2025
Merged
Retrieve floating commands and add abstract wrappers to conftest#600proprogrammer504 merged 2 commits intomainfrom
proprogrammer504 merged 2 commits intomainfrom
Conversation
…cept abstract_wrappers.
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
camspec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #574
Created a method under CommandsWrapper which retrieves all current "floating" commands. A floating command here is defined as any command whose id does not match up with any command_id in the PacketCommands table.
New Changes
retrieve_floating_commands() -> list (Commands)
Extended the conftest to accept the abstracted wrappers
Wrote pytests for it
Testing
Pytests include 2 cases: One where PacketCommands is empty and one where PacketCommands is nonempty.
For the empty one, we expect that after calling retrieve_floating_commands(), we get the all the commands currently in the Command table. For the non empty PacketCommands, we expect the complement of PacketCommands and Commands where PacketCommands is the universal set :).