Skip to content

Conversation

@erinjhu
Copy link

@erinjhu erinjhu commented Jan 13, 2026

Purpose

Closes #441 but still need to test on board
Updated old pr: #276

New Changes

  • Functions to get shunt voltage, bus voltage, current, power values: obc/app/drivers/ina230/ina230.c
  • Mock data for i2c to test driver functions: obc/app/drivers/ina230/ina230.h and test/mocks/mock_i2c_hal.c
  • Unit tests: test/test_obc/unit/test_ina230.cpp

Testing

  • I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have tested this PR on a board if the code will run on a board (Only required for firmware developers).
  • I have tested this PR by running the ARO website (Only required if the code will impact the ARO website).
  • I have tested this PR by running the MCC website (Only required if the code will impact the MCC website).
  • I have included screenshots of the tests performed below.

Outstanding Changes

  • Test on board
  • Make scalable for more than 2 devices

@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
Adityya-K
🥇
40
▀▀▀▀
3d 20h 30m
102
▀▀
camspec
🥈
38
▀▀▀▀
2d 18h 47m
225
▀▀▀▀▀
proprogrammer504
🥉
11
7d 1h 30m
▀▀
43
kepler452b123
8
1d 18h 25m
24
Syzygicality
5
13h 13m
8
joannalauu
3
4d 21h 20m
19
c4bae
1
13d 1h 35m
▀▀▀▀
2

⚡️ Pull request stats

Copy link
Contributor

@Adityya-K Adityya-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed through the PR, will look at thoroughly during testing!

return OBC_ERR_CODE_SUCCESS;
}

// Notes (delete later)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll drop this as a reminder to clean up the comments. Don't resolve this until all the comments are good (preferably they get cleaned up right before merge since they might be useful during testing!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement INA230 sensor driver

3 participants