Abdullah/mcc frontend #658
Conversation
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
camspec
left a comment
camspec
left a comment
There was a problem hiding this comment.
Overall, the page looks great! I'm a big fan of the design but there are a few small issues with the CSS. Since the page is missing functionality for now, I'm not worried about implementation details yet. Really well done with the formatting and semantic labelling.
| </div> | ||
|
|
||
| {/* Submit Button */} | ||
| <button |
There was a problem hiding this comment.
In general, all your buttons are missing cursor properties
gs/frontend/mcc/src/pages/Signup.tsx
Outdated
|
|
||
| return ( | ||
| <div className="flex flex-col items-center h-screen overflow-y-auto px-4 py-8"> | ||
| <div className="w-full max-w-2xl bg-gray-900/50 backdrop-blur-sm rounded-lg p-8 border border-gray-700/50 my-auto"> |
There was a problem hiding this comment.
This div has overflow issues at both the bottom and top when the Account Type is set to Operator, since the form is much longer. Consider adding margin or overflow
camspec
left a comment
camspec
left a comment
There was a problem hiding this comment.
Looks great, just one small change
| @@ -9,7 +9,7 @@ | |||
| border-color: var(--border); | |||
| } | |||
| body { | |||
There was a problem hiding this comment.
The signup and login components should be centered vertically on the page and locked in place unless the form is long enough to overflow. Right now if the screen is large enough to display the whole form, it's still partially scrollable and isn't centered on the page
2 participants
Purpose
Closes #619.
New Changes
Testing
I was indicated by a PM that all I needed for this specific issue was the explanation of changes and screenshot of the figma design. Since the frontend was already not connected to the backend, and i am only implementing the figma design of 2FA authentication, thus there isn't really any major things to test for here.