Skip to content

Conversation

@JonathanmZhang
Copy link

Purpose

Closes #655
Explain the purpose of the PR here if it doesn't match the linked issue. Be sure to add a comment in the linked issue explaining the changes.

New Changes

  • Identify a proper format for each csv column

  • Each csv column will only contain all capital letters, numbers (if necessary) and special characters (if necessary).

  • If there are middle names, they will be included. If there is only an initial that will be included.

  • any unnecessary characters such as quotations in names have been removed

  • Clean the data to fit the format

  • Only modify the csv

Testing

Explain tests that you ran to verify code functionality.

  • I have unit-tested this PR. Otherwise, explain why it cannot be unit-tested.
  • I have just reformatted the data to follow a standardized formatting.

Outstanding Changes

If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
camspec
🥇
36
▀▀▀▀
3d 2h 35m
204
▀▀▀▀▀
Adityya-K
🥈
28
▀▀▀
4d 3m
92
▀▀
proprogrammer504
🥉
16
▀▀
2d 12h 39m
51
Syzygicality
9
20h 9m
27
kepler452b123
4
4d 2h 17m
1
joannalauu
3
4d 21h 20m
19
c4bae
1
13d 1h 35m
▀▀▀▀
2
panthpatel2016
1
4h 30m
6

⚡️ Pull request stats

@JonathanmZhang JonathanmZhang changed the title updated callsigns csv Formatted callsigns csv Jan 25, 2026
Copy link
Contributor

@proprogrammer504 proprogrammer504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its probably fine, but if u dont mind, could u send an ss into the gs or software general channel and ping @k.wan (thats me)? git doesnt want to load the diffs for this pr, so id like to know exactly what changes were made. based on my understanding of this task, it seems like the task was to validate that callsigns are formatted correctly, and if they are not, correct the formatting.

Copy link
Contributor

@proprogrammer504 proprogrammer504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the changes should not affect verification, or any code relating to parsing the callsigns. the largest changes was that the all entries are capitalized, and names are cleaned as signs such as periods, or quotation marks were removed.

However, it should be noted that quotations could indicate preferred name / legal name so it may be worth another check.

Copy link
Contributor

@Syzygicality Syzygicality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues:

  • The callsign migration script (run via python3 gs/backend/migrate.py) no longer works, as a special character is preventing the csv from being parsed by callsigns.py (see line 215 for the breaking character)
  • The first names column (2nd from the left) still contains middle names, please remove
  • Please add double quotation marks to all addresses from the csv
  • On closer inspection, there are rgb values for some reason? (see line 247) please resolve
  • Enforce single spacing, some fields contains multiple spacing (see line 1064)
  • ensure that migrate.py can run by testing callsigns.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean Callsign CSV

3 participants