[Vaultwarden] Hint at problems with default Web Security Headers #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guide should be amended by a hint towards uberspaces default Web Security Headers which might interfere with 2-step login and or notifications. Refer to https://github.com/dani-garcia/vaultwarden/blob/8d1df08/src/util.rs lines 38 and 73
|
I am not too experienced writing documentation, this is just what I would have needed in the guide |
nichtmax
requested changes
Jun 10, 2025
|
|
||
| .. note:: | ||
| The default nginx config defines `X-Frame-Options: SAMEORIGIN` for all web backends. This may cause compatibility issues with the 2-step login feature and desktop/mobile clients as well as notifications on websockets. | ||
| If you encounter these issues, you may want to consider suppressing that header for relevant paths i. e. /*connector.html, /notifications/hub, /notifications/anonymous-hub, refer to the :manual:`web-security-headers manual<web-security-headers>`. |
There was a problem hiding this comment.
It would be nice if you told how exactly to suppress these headers in this case.
There was a problem hiding this comment.
@JayBraker any updates on this? If not, we'll close this PR soon.
There was a problem hiding this comment.
Thank your for the reminder.
I amended my proposal for a snippet/codeblock and rephrased the note to make a little more sense in combination with the snippet.
There was a problem hiding this comment.
um.. did you? 😅 I can't find any additional commit. Could you please check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guide should be amended by a hint towards uberspaces default Web Security Headers which might interfere with 2-step login and or notifications.
Refer to https://github.com/dani-garcia/vaultwarden/blob/8d1df08/src/util.rs lines 38 and 73
Also see #1901