[Feature]: Extends Pull Request #152 Regarding Docker File and Configuration#172
[Feature]: Extends Pull Request #152 Regarding Docker File and Configuration#172sanketshivale wants to merge 5 commits into
Conversation
sanketshivale
commented
Mar 4, 2024
sanketshivale
commented
- Added and Refactored Dockerfile to utilize Docker's layer caching feature for faster builds .
- Updated README.md for installation and setup of Docker.
- Optimized Dockerfile by copying requirements.txt first, followed by the rest of the project files later so that we can use caching on build.
- Updated integration.py for get_monitor fixes in Docker.
|
Great to see quick action! Please add a screenshot or short video recording of how it's working on the machine if possible :) |
Udayraj123
changed the title
|
Yes for sure !! Here is the screen recording of the build and run process of docker of OMRChecker. simplescreenrecorder-2024-03-06_01.06.23.mp4 |
| # If running in a container, make a fake monitor | ||
| monitor_window = ( | ||
| Monitor(0, 0, 1000, 1000, 100, 100, "FakeMonitor", False) | ||
| if os.environ.get("OMR_CHECKER_CONTAINER") |
There was a problem hiding this comment.
I think we shall also disable the call for imshow using this code change -
def show(name, origin, pause=1, resize=False, reset_pos=None, config=None):
if(os.environ.get("OMR_CHECKER_CONTAINER")):
return
There was a problem hiding this comment.
I required some assistance with these. As of now, I understand that we aim to refrain from displaying image metrics in DOCKER CONTAINER. If I am correct in this understanding, then with my current knowledge, I attempted to address the issue on my end. Please let me know if any clarification is needed.
There was a problem hiding this comment.
You can test it once by setting show_image_level to 5 in one of the samples, the code should still finish without any errors. If that works fine, above change should suffice.
|
Thanks for getting this across the finish line. The last 6 months have been very busy for me. |
|
I guess I jinxed it 😄. Still pending on review comments and I have one more suggestion now - |
Co-authored-by: Udayraj Deshmukh <Udayraj123@users.noreply.github.com>
|
@Udayraj123 video for the changes Now, the next step in dealing with the devcontainer is to review the pull request. If there are any necessary changes, please share them for improvement. simplescreenrecorder-2024-05-06_23.38.56.mp4 |
|
Great! I'll check this over the weekend and try to get your PR merged! |
| cd OMRChecker/ | ||
| ``` | ||
|
|
||
| 2. Build the Docker container image (Initial build may take up to 2 minutes depending on your network connection): |
There was a problem hiding this comment.
After merging the dev branch, we will also consider publishing a docker image on dockerhub
Udayraj123
dismissed
their stale review
Changing mind to create a dedicated readme for docker setup
|
|
||
| ### Running OMRChecker in Docker | ||
|
|
||
| Once Docker is installed, you can run OMRChecker within a Docker container by following these steps: |
There was a problem hiding this comment.
Let's move this section into a dedicated file.
| Once Docker is installed, you can run OMRChecker within a Docker container by following these steps: | |
| For running OMRChecker using docker, please check the [readme-docker.md](https://github.com/Udayraj123/OMRChecker/tree/master/readme-docker.md) |
Move this section details into a top level file readme-docker.md
|
Almost forgot the docker compose file from this PR. I think we should add that too! |
3 participants
