You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR is incomplete as it only adds a template.json file for a new sample without the necessary corresponding image file, rendering the sample unusable. The suggestion is to add the missing image to the samples/sample99 directory.
# Directory structure in the PRsamples/└── sample99/└── template.json
After:
# Expected directory structure after applying the suggestionsamples/└── sample99/├── template.json└── corresponding_image.jpg
Suggestion importance[1-10]: 10
__
Why: This suggestion correctly identifies a critical omission; the PR is unusable without the corresponding image file, failing to meet its primary objective.
The reason will be displayed to describe this comment to others. Learn more.
0 bytes file? Can you check again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
I have added a new sample folder containing a template and an image to help expand the test dataset. Ref: #40
PR Type
Documentation
Description
Add new sample dataset (sample99) with template configuration
Include template.json with bubble detection and field block settings
Provide test data for OMR sheet processing pipeline
Diagram Walkthrough
File Walkthrough
template.json
Template configuration for sample99 OMR datasetsamples/sample99/template.json
(0-9)