Improve README formatting and add usage example#284
Open
Jags-08 wants to merge 1 commit into
Open
Conversation
Review Summary by QodoImprove README with grammar fixes and usage example
WalkthroughsDescription• Fix grammar in library installation section • Add comprehensive usage example with step-by-step instructions • Improve README clarity for new users Diagramflowchart LR
A["README.md"] -->|"Grammar correction"| B["Installation section"]
A -->|"Add new section"| C["Usage Example"]
C -->|"Includes"| D["Step-by-step workflow"]
C -->|"Includes"| E["Code snippet"]
File Changes1. README.md
|
Code Review by Qodo
1. Template path requirement missing
|
Comment on lines
+256
to
+262
| 1. Place your scanned OMR sheets in a folder, such as `inputs/`. | ||
| 2. Create or copy your layout definition into a `template.json` file. | ||
| 3. Run the checker script targeting your inputs: | ||
|
|
||
| ```bash | ||
| python3 main.py --inputDir inputs/ --outputDir outputs/ | ||
| ``` |
There was a problem hiding this comment.
1. Template path requirement missing 🐞 Bug ≡ Correctness
The new Usage Example does not state that template.json must be located inside the directory tree rooted at --inputDir; if users put template.json elsewhere (e.g., repo root) and run with --inputDir inputs/, the program raises "No template file found in the directory tree" and exits. This makes the documented workflow fail for a common interpretation of step (2).
Agent Prompt
## Issue description
The README "Usage Example" omits where `template.json` must be placed relative to `--inputDir`. The code only discovers `template.json` inside the directory tree rooted at the provided input directory and raises an exception if images are found without a discovered template.
## Issue Context
Users may reasonably interpret step (2) as creating `template.json` in the repo root (or current working directory) and then run `--inputDir inputs/`. That setup fails because `template.json` is not searched outside the input directory tree.
## Fix Focus Areas
- README.md[247-262]
## Suggested documentation change
Update the steps to explicitly say one of the following:
- Place `template.json` inside `inputs/` (or an ancestor directory *within* the `--inputDir` tree), e.g. `inputs/template.json`.
- Or, if you want `template.json` to live in a parent folder of multiple scan subfolders, set `--inputDir` to that parent folder (the one containing `template.json`).
Optionally add a small directory tree example to remove ambiguity.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Author
|
Hi! I’ve made a small improvement to the README to enhance clarity and usability. Please let me know if any changes are needed. I’d be happy to update it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the README by enhancing formatting and adding a basic usage example to make the project easier to understand.
Let me know if any changes are needed.