Skip to content

feat(uipath-maestro-flow): edit write instruction fixes#523

Merged
rockymadden merged 2 commits intomainfrom
feat/uipath-maestro-flow-edit-write-fixes
May 1, 2026
Merged

feat(uipath-maestro-flow): edit write instruction fixes#523
rockymadden merged 2 commits intomainfrom
feat/uipath-maestro-flow-edit-write-fixes

Conversation

@rockymadden
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Claude finished @rockymadden's task in 3m 7s —— View job


PR Review: feat(uipath-maestro-flow): edit write instruction fixes

  • Gather context (read review criteria, diff, changed files)
  • Review changes against skill standards
  • Post review findings

Summary

This PR repositions Edit/Write as the default mutation tool for .flow files across the maestro-flow skill, demoting the uip maestro flow node/edge/variable CLI from co-default to an opt-in carve-out. The change touches 5 files (SKILL.md rule #9, CAPABILITY.md critical rules, brownfield.md, greenfield.md, editing-operations.md Tool Selection Ladder) with +26/−23 lines.

Change-by-Change Review

1. skills/uipath-maestro-flow/SKILL.md (+1/−1)

Severity: OK

Rule #9 rewritten to frame Edit/Write as the default and CLI as a carve-out. The new wording is clear and consistent with the editing-operations.md restructuring. The carve-out scope (connector, connector-trigger, inline-agent) matches across all files. The link to references/author/references/editing-operations.md#tool-selection-ladder resolves correctly.

2. skills/uipath-maestro-flow/references/author/CAPABILITY.md (+16/−15)

Severity: OK

New critical rule #2 inserted: "Default to Edit / Write for every .flow mutation." All subsequent rules renumbered correctly (old 2→3, 3→4, … 15→16). The anti-pattern cross-reference updated from "rule #12" to "rule #13" — verified this now correctly points to the "Always run flow tidy after edits" rule. The editing-operations.md link at line 23 (references/editing-operations.md) resolves correctly from CAPABILITY.md's location. The reference in editing-operations.md:43 to "Rule #6" (targetPort) is also correct under the new numbering.

3. skills/uipath-maestro-flow/references/author/references/brownfield.md (+1/−1)

Severity: OK

Self-check reordered from uip maestro flow ..., Edit, WriteEdit, Write, uip maestro flow .... Correctly reflects the new default-first ordering. Consistent with the same self-check wording in greenfield.md.

4. skills/uipath-maestro-flow/references/author/references/editing-operations.md (+4/−4)

Severity: OK

Tool Selection Ladder restructured:

  • Rung 1 (unchanged): connector/connector-trigger/inline-agent → CLI carve-out
  • Rung 2 (expanded): all other .flow mutationsEdit (previously this was rung 3 for tweaks only; now absorbs the old rung 2 CLI add/delete)
  • Rung 3 (moved from 4): wholesale rewrite → Write
  • Rung 4 (demoted from 2): CLI for OOTB add/delete → opt-in only
  • Rung 5 (unchanged): scripting → last resort

The intro sentence is updated to add "and is allowed by default" + the opt-in clarification for rung 4. The Strategy Selection Matrix (lines 36–58), Default Strategy section (lines 24–30), and "Mixing strategies" note (line 59–61) are all already consistent with Edit/Write-as-default — no stale references.

5. skills/uipath-maestro-flow/references/author/references/greenfield.md (+4/−2)

Severity: OK

Step 4 restructured: the default-tool statement is now a blockquote callout (cleaner visual separation), the editing-operations.md reference is pulled into its own line, and the self-check reordered to Edit, Write, uip maestro flow .... The net +2 lines come from the improved structure. All links resolve.

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter OK No frontmatter changes
E2E Tests OK Existing tests under tests/tasks/uipath-maestro-flow/ — this is a documentation-only instruction priority change, not a new capability
Skill Body OK Rule numbering, cross-references, and tool hierarchy consistent across all 5 files
References & Assets OK All relative links verified; no broken references
Repo Hygiene OK No secrets, no cross-skill references, changes scoped to uipath-maestro-flow

Issues for Manual Review

  • Behavioral impact: This is a significant shift in agent behavior — demoting CLI to opt-in means agents will default to raw JSON edits via Edit for node/edge add/delete operations. The CLI previously auto-managed definitions[], variables.nodes, and layout state. Agents using Edit must now handle these cross-cutting concerns manually per the editing-operations-json.md recipes. Verify that the Edit/Write recipes in editing-operations-json.md are complete enough to cover everything the CLI previously auto-managed.

Conclusion

Clean PR. The 5 changed files are internally consistent — rule numbering, cross-references, tool hierarchy framing, and self-check ordering all align with the new "Edit/Write default, CLI carve-out" model. No broken links, no stale references, no structural issues. Approve.

@rockymadden rockymadden merged commit d7766d3 into main May 1, 2026
7 checks passed
@rockymadden rockymadden deleted the feat/uipath-maestro-flow-edit-write-fixes branch May 1, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants