fix: use wildcard for llm.model_name in MCP trace tests#440
Merged
cristipufu merged 2 commits intomainfrom Jan 21, 2026
Merged
Conversation
Chibionos
pushed a commit
that referenced
this pull request
Jan 20, 2026
Extended the wildcard fix to all remaining test files with hardcoded LLM model versions: - company-research-agent: gpt-4.1-mini-2025-04-14 → "*" - init-flow: gpt-4o-mini-2024-07-18 → "*" - ticket-classification: gpt-4.1-mini-2025-04-14 → "*" This ensures all trace validation tests are resilient to future LLM Gateway model changes, preventing CI/CD failures when defaults update. Related to: #440
Replace hardcoded model version with wildcard to prevent test failures when LLM Gateway defaults change. This improves long-term test stability. Previous fix updated model to gpt-4.1-mini-2025-04-14, but this will break again on next model update. Wildcard approach is resilient to future changes. Changes: - llm.model_name: "gpt-4.1-mini-2025-04-14" → "*" - Removed exact content match (varies by model wording) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Extended the wildcard fix to all remaining test files with hardcoded LLM model versions: - company-research-agent: gpt-4.1-mini-2025-04-14 → "*" - init-flow: gpt-4o-mini-2024-07-18 → "*" - ticket-classification: gpt-4.1-mini-2025-04-14 → "*" This ensures all trace validation tests are resilient to future LLM Gateway model changes, preventing CI/CD failures when defaults update. Related to: #440
b76b0f4 to
548521e
Compare
cristipufu
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded LLM model version with wildcard (
*) in trace test expectations to prevent future test failures when models are updated.Problem
The
simple-local-mcptest expectations were recently updated to usegpt-4.1-mini-2025-04-14, but this approach is brittle - it will break again the next time:Solution
Use wildcard matching for
llm.model_nameinstead of exact version:Also removed exact content matching for the final response, as wording can vary slightly between models.
Benefits
✅ Future-proof: Won't break on model updates
✅ Environment-agnostic: Works regardless of which model is configured
✅ Lower maintenance: No need to update test expectations when models change
✅ Still validates: Provider (
azure), system (openai), and span structure are still checkedImplementation
The trace assertion logic (
trace_assert.py) already supports wildcards:Testing
This change only affects test expectations, not runtime behavior. The wildcard will accept any model name while still validating:
🤖 Generated with Claude Code