Conversation
ionmincu
force-pushed
the
fix/char_vertex_streaming
branch
3 times, most recently
from
11afaea to
b0c16f2
Compare
ionmincu
force-pushed
the
fix/char_vertex_streaming
branch
from
b0c16f2 to
cc98864
Compare
cristipufu
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChatVertex was simulating streaming because of a bug in llm gateway. We simulated
streamwith a simpleinvokein the past. This Pr removes the fakestreamandastreamto allow the base to use actuall streaming.