fix: unwrap PEP 604 union types (X | None) in _unwrap_optional#800
Merged
radu-mocanu merged 1 commit intomainfrom Apr 23, 2026
Merged
fix: unwrap PEP 604 union types (X | None) in _unwrap_optional#800radu-mocanu merged 1 commit intomainfrom
radu-mocanu merged 1 commit intomainfrom
Conversation
b99805d to
aa9a294
Compare
radugheo
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X | Nonesyntax_unwrap_optionalnow handles bothtyping.Union(Optional[X]) andtypes.UnionType(X | None)Why
on Python 3.10-3.13,
get_origin(X | None)returnstypes.UnionTypeinstead oftyping.Union. the_unwrap_optionalcheck was only testing fortyping.Union, soAttachment | Nonefield annotations were never unwrapped toAttachment, causingget_job_attachment_pathsto return no paths andjob_attachmentsto stay empty. Python 3.14 changedget_originto returntyping.Unionfor both forms, masking the bug locally.Development Package
uipath pack --nolockto get the latest dev build from this PR (requires version range).