fix: decouple mocking from evals#1148
Merged
akshaylive merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
github-actions
Bot
added
test:uipath-langchain
cristipufu
commented
Jan 18, 2026
cristipufu
force-pushed
the
fix/decouple_mocking
branch
3 times, most recently
from
a583ab4 to
0f86c8f
Compare
cristipufu
force-pushed
the
fix/decouple_mocking
branch
from
0f86c8f to
631956b
Compare
cristipufu
commented
Jan 18, 2026
akshaylive
reviewed
Jan 18, 2026
Collaborator
akshaylive
left a comment
akshaylive
left a comment
There was a problem hiding this comment.
Looks great overall. We do need to figure out the details regarding agentInfo and evaluation_criterias in a debug context.
mjnovice
reviewed
Jan 20, 2026
cristipufu
force-pushed
the
fix/decouple_mocking
branch
2 times, most recently
from
442ee42 to
f468cd6
Compare
cristipufu
force-pushed
the
fix/decouple_mocking
branch
from
f468cd6 to
e44e2f8
Compare
akshaylive
approved these changes
Jan 21, 2026
| evaluation_item: EvaluationItem, | ||
| mocking_strategy: InputMockingStrategy, | ||
| input_schema: dict[str, Any], | ||
| expected_behavior: str, |
Collaborator
There was a problem hiding this comment.
Let's make this Optional[str] and Optional[dict[str, Any]] respectively please
| if evaluation_item.input_mocking_strategy | ||
| else None | ||
| ) | ||
| model_parameters = mocking_strategy.model if mocking_strategy else None |
Collaborator
There was a problem hiding this comment.
This line can be removed -- mocking_strategy cannot be None here.
mjnovice
added a commit
that referenced
this pull request
Jan 21, 2026
Now that mocking is decoupled from evals (PR #1148), update the debug command to use MockingContext directly instead of creating a dummy EvaluationItem. This simplifies the code and better reflects the separation of concerns. Changes: - Update load_simulation_config to return MockingContext instead of EvaluationItem - Replace EvaluationSimulationTool with ToolSimulation - Update all tests to work with MockingContext - Remove unnecessary evaluation_criterias field Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decouples mocking from evaluation context.
Ref: #1117
Development Package
uipath pack --nolockto get the latest dev build from this PR (requires version range).