Skip to content

Fix unreliable renet2 channels used with websockets#45

Merged
UkoeHB merged 8 commits into
mainfrom
unreliable_reliable
Apr 18, 2026
Merged

Fix unreliable renet2 channels used with websockets#45
UkoeHB merged 8 commits into
mainfrom
unreliable_reliable

Conversation

@UkoeHB
Copy link
Copy Markdown
Owner

@UkoeHB UkoeHB commented Apr 11, 2026

Fixes #43

@UkoeHB UkoeHB requested a review from Shatur April 11, 2026 19:36
@UkoeHB
Copy link
Copy Markdown
Owner Author

UkoeHB commented Apr 11, 2026

@alexthill can you test if this PR fixes your issue?

@alexthill
Copy link
Copy Markdown

I tested the change and both the example echo server and my own application now work as expected with WebSockets. Thank you.

One nitpick: These comments should probably be doc-comments?

// Messages can be lost or received out of order.
Unreliable {
// Should only be `true` if the underlying transport is ordered and reliable (e.g. WebSockets or in-memory channels)
// and reliability is desired. Can be set to `false` if reliability is not required.`
ordered_reliable_substrate: bool,
},

@UkoeHB UkoeHB merged commit 07227b5 into main Apr 18, 2026
3 of 4 checks passed
@UkoeHB UkoeHB deleted the unreliable_reliable branch April 18, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocket drops packages when sending more than available_bytes_per_tick

2 participants