Skip to content
This repository was archived by the owner on Jun 30, 2026. It is now read-only.

Save fit in ranges - #686

Open
Geegee wants to merge 7 commits into
masterfrom
save_fit_in_ranges
Open

Save fit in ranges#686
Geegee wants to merge 7 commits into
masterfrom
save_fit_in_ranges

Conversation

@Geegee

@Geegee Geegee commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

Previously -1 was introduced as an indicator for all ranges combined.
Now this is followed through the whole tool chain.

Description

This includes:
- saving
- display of the whole matrix range
Additionally some clarifying tool tips were added.

Motivation and Context

This should bring as added benefit the changes intended in #681

How Has This Been Tested?

On dummy. I tried saving under different scenarios. Certainly not exhaustive.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants