Skip to content

Conversation

@rburema
Copy link
Member

@rburema rburema commented Jul 4, 2024

See the matching backend PR for the full story.

CURA-11887

Fixes #18859 (comment)

rburema and others added 4 commits July 4, 2024 08:52
Give the user more control over what is considered 'inside' or 'outside' of the model when the 'outside only' option is on for 'magic fuzzy skin'/'outer wall jitter'.

part of CURA-11887
Policy to not confuse already existing users.

part of CURA-11887
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names and descriptions are a bit hard to read, but I think that's the best we can have 😅
Also shouldn't we set settable_pre_extruder to True, or is it implied by settable_per_mesh ?

@rburema
Copy link
Member Author

rburema commented Jul 9, 2024

The names and descriptions are a bit hard to read, but I think that's the best we can have 😅

Yeah, there's only two big problems in programming, and they're the halting problem, naming things and off by one errors :-p

Also shouldn't we set settable_pre_extruder to True, or is it implied by settable_per_mesh ?

I'm not sure if that's implied, can't hurt to add it. - I'll make a commit later.

@rburema
Copy link
Member Author

rburema commented Jul 9, 2024

Ah no actually, I remember why I did that; this is the way enabling fuzzy skin also works. So I'm not going to mess with this further (and just focus on the bugs we still have for beta).

@wawanbreton
Copy link
Contributor

Oh yes, makes sense. You don't really want to enable it by extruder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuzzy Skin never Outside Only

3 participants