Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZYYX Pro profile bugfix #20160

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

theodorhansson
Copy link
Contributor

@theodorhansson theodorhansson commented Jan 21, 2025

Description

There was an issue with the ZYYX Pro's selection of profiles related to its many nozzles. It caused the wrong profile to be selected.

Fixed by removing erroneous "global_quality=True" from material-specific quality profiles.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested the new profiles and they seem to update correctly now. The version before this does not update.

Test Configuration:

  • MacOS

Checklist:

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Test Results

23 380 tests  ±0   23 378 ✅ ±0   44s ⏱️ -4s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 49be241. ± Comparison against base commit 0a936be.

♻️ This comment has been updated with latest results.

@theodorhansson
Copy link
Contributor Author

@wawanbreton I found a stupid bug in the ZYYX profiles I made earlier. Could you have a short look at it?

@theodorhansson theodorhansson marked this pull request as ready for review February 3, 2025 11:22
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theodorhansson, to be honest I don't know exactly what this attribute means, but it seems to be reserved for some specific profiles indeed. And if you tell me this is an improvement, I do believe you 🙂

@wawanbreton wawanbreton merged commit 97deb2f into Ultimaker:main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants