Skip to content

[CURA-12446] Added settings for a different number of walls in top-/bottom-most skin. #20565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rburema wants to merge 11 commits into
base: 5.11
Choose a base branch
from
Open

[CURA-12446] Added settings for a different number of walls in top-/bottom-most skin. #20565

rburema wants to merge 11 commits into from

Conversation

@rburema
Copy link
Member

@rburema rburema commented Apr 30, 2025 •
edited
Loading

See also engine PR: Ultimaker/CuraEngine#2227

@rburema rburema mentioned this pull request Apr 30, 2025
Open
@rburema rburema marked this pull request as draft April 30, 2025 14:28
@rburema
Copy link
Member Author

rburema commented Apr 30, 2025

  • (label) name may not be OK yet, '... Skin' could confuse people into thinking its multiple layers instead of top/bottom most (exposed to air)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025 •
edited
Loading

Test Results

24 506 tests  +24 506   24 504 ✅ +24 504   47s ⏱️ +47s
     1 suites +     1        2 💤 +     2 
     1 files   +     1        0 ❌ ±     0 

Results for commit 753501c. ± Comparison against base commit e599196.

♻️ This comment has been updated with latest results.

@rburema
Make the previously 'bottom' wall line count only apply to initial.
cc55ef7 
Otherwise the walls will adhere less well to the model, and while this is a nice visual change, structural integrity (especially when briding) is more important. Also this is what it already says in the ticket is needed, nothing really specified about non-top, non-initial layers.

part of CURA-12446
@rburema rburema marked this pull request as ready for review May 6, 2025 09:55
@wawanbreton
Copy link
Contributor

wawanbreton commented May 7, 2025

  • (label) name may not be OK yet, '... Skin' could confuse people into thinking its multiple layers instead of top/bottom most (exposed to air)

You can have a look at flooring_extruder_nr and roofing_extruder_nr for the wording, which is slightly different, not sure it is better but at least it would be consistent.

wawanbreton
wawanbreton reviewed May 7, 2025
View reviewed changes
@jellespijker jellespijker requested a review from Copilot May 9, 2025 05:27
Copilot AI reviewed May 9, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • resources/definitions/fdmprinter.def.json: Language not supported

rburema
rburema commented Jun 17, 2025
View reviewed changes
rburema
rburema commented Jun 17, 2025
View reviewed changes
@wawanbreton wawanbreton changed the base branch from main to 5.11 October 10, 2025 08:53
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Error Files:

  • 'File: resources/definitions/bambulab_a1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/definitions/bambulab_a1mini.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/definitions/bambulab_base.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/definitions/bambulab_x1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_0.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_2.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1_extruder_3.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_0.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_2.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_a1mini_extruder_3.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_0.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_1.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_2.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/extruders/bambulab_x1_extruder_3.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1_0.4_PLA_standard.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1mini_0.4_PLA_standard.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_a1mini_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_x1_0.4_PLA_standard.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/quality/bambu/bambulab_x1_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/variants/bambu/bambulab_a1_0.4.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/variants/bambu/bambulab_a1mini_0.4.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
  • 'File: resources/variants/bambu/bambulab_x1_0.4.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wawanbreton wawanbreton wawanbreton approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rburema @wawanbreton @HellAholic