-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update PurgeLinesAndUnload.py #20660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes an exception thrown upon a clean start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an exception thrown on a clean start by refactoring the initialization method in PurgeLinesAndUnload.py.
- Introduces a new initialize() method that calls super().initialize() and sets up the global stack.
- Removes a duplicate initialize() definition to consolidate initialization logic.
Comments suppressed due to low confidence (2)
plugins/PostProcessingPlugin/scripts/PurgeLinesAndUnload.py:42
- Using super().initialize() in the new initialize() method is appropriate; please verify that all necessary base class initialization requirements are met.
super().initialize()
plugins/PostProcessingPlugin/scripts/PurgeLinesAndUnload.py:41
- The duplicate initialize() method has been removed. Please confirm that any initialization logic previously handled in the removed block has been fully integrated into the new method.
def initialize(self) -> None:
wawanbreton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, maybe a some point we should update SearchAndReplace.py (which is referenced as being the example plugin) so that it also has a basic overridden initialize function
Fixes an exception thrown upon a clean start.
Description
Type of change
How Has This Been Tested?
Test Configuration: