Correct calculation of initial bottom layers & clean up #21166
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: Community Contribution 👑
Contributor
Test Results24 506 tests +24 506 24 498 ✅ +24 498 49s ⏱️ +49s For more details on these errors, see this check. Results for commit c984744. ± Comparison against base commit db86084. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
These changes are intended to calculate the correct number of layers when slicing a model before printing. This only works in specific scenario where the
Initial Layer Heightis different than theLayer Height. In addition to the correct calculation, we obtain the correct layers result on the slider.Note
Most users don't notice the issue because
Initial Bottom Layersis not shown by default (even in Expert settings) and even fewer users check these values.Important
Please note that the calculation of the number of layers is always based on the layer thickness value.
Description of changes
Line 1739: The formula for calculating the number of
Initial Bottom Layersshows the correct values finally.Line 3766: the formula "* 30 / 60" is easier to write as "/ 2"
Line 7269: the formula "/ 60 * 30" is easier to write as "/ 2"
Type of change
How Has This Been Tested?