Show layer height in Simulation View slider labels #21201
Conversation
Adds display of the current and minimum layer heights (in mm) to the Simulation View slider labels. Implements new properties and logic in SimulationView and SimulationViewProxy to retrieve accurate layer heights for both sliced and gcode data. Bumps plugin version to 1.1.0.
HellAholic
added
Type: Improvement
| @pyqtProperty(float, notify=currentLayerChanged) | ||
| def currentLayerHeight(self): | ||
| return self._simulation_view.getCurrentLayerHeight() | ||
|
|
||
| @pyqtProperty(float, notify=currentLayerChanged) | ||
| def minimumLayerHeight(self): | ||
| return self._simulation_view.getMinimumLayerHeight() |
There was a problem hiding this comment.
These will recalculate (go through the entire scene, for every layer) each time, every time you request an update.
Please cache this at the very least, but even better, just go through the layers once on receiving them, and then save all of that; then you can query that structure.
Introduced a cache for layer heights to avoid recalculating them on every query. Added a method to populate the cache for all layers at once, and updated layer height retrieval methods to use the cache, improving efficiency when accessing layer height data.
|
"Feature Request" #7683 is slightly different. They wanted the "Time Remaining" added to the slider as well. |
|
For displaying Time we need to return time per layer from the engine side, the layer message only has id, height, thickness. |
|
Everything was working fine until I started playing with Aldo's plugins (trying to get them to work in 5.11). 
|
|
it works for me with aldos tabbed & sidebar plugins apart from a niche case where if I'm in the preview tab, change a setting, hit slice, wait for the model to grey out then switch to the prepare tab while it's slicing. When the slice completes & I switch back to the preview tab wherever the slider is reports 0.00mm until I move the slider where it starts to display the height again. I didn't see this scenario as worthy of a bug post given the minimal impact |
Added logic to track which node's layer heights are cached and only recalculate the cache if the data source changes. This improves performance by avoiding unnecessary recalculations and ensures cache validity when the scene changes.
Updated the caching logic in SimulationView to use the id of the layer_data object instead of the node. This ensures the cache is correctly invalidated when layer_data changes, preventing potential issues when nodes are reused.
|
I added the last commit and it looks good now. |
Still working here too. The observation I made above still exists but I could live with that I did tinker with my install of the SimulationSliderLabel.py so the layer height box matches the height of layer no. box. I don't know if it would work for everyone or if you think that is worthy of a change to the official version 
|
|
Another long-time feature request bites the dust. Congratulations!! (No one will ever know that it was all because you didn't want to write a calculator into "HellaFusion") |
|
I'm too lazy to write it in the plugin, I'll do many times the work just to avoid the work 🤣 |
Description
Adds display of the current and minimum layer heights (in mm) to the Simulation View slider labels. Implements new properties and logic in SimulationView and SimulationViewProxy to retrieve accurate layer heights for both sliced and gcode data. Bumps plugin version to 1.1.0.
Adaptive layer height + Raft
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: