Printer definition lint #21236
Open
Printer definition lint #21236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted the material_standby_temperature setting from the Anycubic Kobra 3V2 ACE PRO definition file, likely to streamline or correct printer configuration.
Changed the 'material_standby_temperature' value to use resolveOrValue('material_print_temperature') for improved parameter resolution and consistency.
Changed the 'material_standby_temperature' value to use resolveOrValue('material_print_temperature') for improved parameter resolution and consistency.
Changed the 'material_standby_temperature' value to use resolveOrValue('material_print_temperature') for improved parameter resolution.
Changed the value of material_standby_temperature to use resolveOrValue('material_print_temperature') instead of directly referencing material_print_temperature. This may improve dynamic resolution of the standby temperature setting.
Changed the value of material_standby_temperature to use resolveOrValue('material_print_temperature') for improved parameter resolution.
Changed the 'material_standby_temperature' value to use resolveOrValue('material_print_temperature') for dynamic resolution in deltacomb_dc30flux.def.json.
Changed the value of 'material_standby_temperature' to use resolveOrValue('material_print_temperature') for improved dynamic resolution.
Changed the value of material_standby_temperature to use resolveOrValue('material_print_temperature') for improved parameter resolution in koonovo_kn3.def.json.
Changed the value of material_standby_temperature to use resolveOrValue('material_print_temperature') for improved dynamic resolution.
Changed the 'material_standby_temperature' value to use resolveOrValue('material_print_temperature') instead of referencing the variable directly. This may improve dynamic resolution of the standby temperature based on the print temperature.
HellAholic
added
PR: Community Contribution 👑
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The material standby temperature is used under preferences, materials tab. This value must be resolved in order to be displayed in the UI. Currently, this will cause a hard crash as it expects a float value but receives a setting name.
Secondary fix: default_value cannot be overridden with a setting function and it does not have a resolve function therefore the final value must be used if the default_value requires an override.
#21234
Few other printer examples were previously fixed.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: