CURA-12264 Fix seam alignment #2167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12264 With a high-definition model, the new vertex created especially for the seam is quite close to the other points of its former segment. So the two other vertices would end up at good enough outsiders for the distance criterion. Now the distance factor of the criterion is a setting, so that in this specific case we can change the value to give more weight to the specific vertex and less to others, even if very close.
rburema
approved these changes
Nov 6, 2024
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
Code seems fine. So far, my tests show that it's about on-par with 5.8.1 so far -- so that's good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12264
With a high-definition model, the new vertex created especially for the seam is quite close to the other points of its former segment. So the two other vertices would end up at good enough outsiders for the distance criterion. Now the distance factor of the criterion is a setting, so that in this specific case we can change the value to give more weight to the specific vertex and less to others, even if very close.