Cura 12275 retract before outer wall only works on the initial layer #2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12275 The travel_retract_before_outer_wall setting is settable per-mesh, but the global value was previously taken in this context. We now take the value of the setting, for the mesh we are moving to.
rburema
approved these changes
Nov 12, 2024
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
Code looks good -- though I know the code won't reach there, it still feels a little risky to return nullptr like that and not check... 😆
rburema
approved these changes
Nov 12, 2024
…ks-on-the-initial-layer
HellAholic
deleted the
CURA-12275_retract-before-outer-wall-only-works-on-the-initial-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
travel_retract_before_outer_wallsetting is settable per-mesh, but the global value was previously taken in this context. We now take the value of the setting, for the mesh we are moving to.CURA-12275
Fixes Ultimaker/Cura#19876