Apply coasting only on walls #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rburema
reviewed
Nov 14, 2024
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 7dff062 | Previous: 880114d | Ratio |
|---|---|---|---|
WallTestFixture/InsetOrderOptimizer_getInsetOrder/3 |
0.0012966536206117077 ms/iter |
0.0008127991601801438 ms/iter |
1.60 |
WallTestFixture/InsetOrderOptimizer_getInsetOrder/15 |
0.0069605387360443085 ms/iter |
0.004478947543079436 ms/iter |
1.55 |
HolesWallTestFixture/InsetOrderOptimizer_getInsetOrder/3 |
0.0003066003938636015 ms/iter |
0.00017590911906887284 ms/iter |
1.74 |
HolesWallTestFixture/InsetOrderOptimizer_getInsetOrder/15 |
0.0013866977338052812 ms/iter |
0.0008506689551831813 ms/iter |
1.63 |
SimplifyTestFixture/simplify_slot_noplugin |
1.8632624587525577 ns/iter |
1.2391182140035724 ns/iter |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
nallath
approved these changes
Nov 15, 2024
…s-No-coasting-on-skin-or-infill
HellAholic
deleted the
CURA-12288_Coasting-only-for-outer-inner-walls-No-coasting-on-skin-or-infill
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12288