-
-
Notifications
You must be signed in to change notification settings - Fork 913
CURA-11978 Retract and unretract in a travel #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HellAholic
merged 42 commits into
main
from
CURA-11978_retract-and-unretract-in-a-travel
Jun 20, 2025
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
f36465d
Basically working retraction during travel
wawanbreton 2250fa1
Basically working priming during travel
wawanbreton 103d1f5
Fix some multi-segment travel with retraction/prime issues
wawanbreton 83fd0b3
Clean code and add documentation
wawanbreton 3908251
Apply clang-format
wawanbreton 6196437
Complete documentation and figure out missing files
wawanbreton 3284964
Merge remote-tracking branch 'origin/CURA-11978_retract-and-unretract…
wawanbreton a24ed92
Make sure z-hop won't change retract when not supposed to
wawanbreton 270b1b5
Add algorithm documentation
wawanbreton 84be5f5
Merge remote-tracking branch 'origin/main' into CURA-11978_retract-an…
wawanbreton ea67713
Apply clang-format
wawanbreton c77c30c
Disable retract during travel for printers that handle retraction
wawanbreton 4426c45
Merge remote-tracking branch 'origin/CURA-11978_retract-and-unretract…
wawanbreton c833194
Properly apply retraction limitations during travel
wawanbreton b157550
Apply suggestions from code review
wawanbreton 75e2cff
Apply clang-format
wawanbreton 9a2c5d3
Remove useless variable initialization
wawanbreton 9143ec5
Merge remote-tracking branch 'origin/CURA-11978_retract-and-unretract…
wawanbreton 5940d31
Add unit test for anti-oozing amounts calculation
wawanbreton 2c5bd6d
Harmless optimization
wawanbreton 6405aaa
Use accumulate to make code more explicit
wawanbreton 4a2cd81
Apply clang-format
wawanbreton c1eba8b
Merge branch 'main' into CURA-11978_retract-and-unretract-in-a-travel
HellAholic cfdf96b
Merge branch 'main' into CURA-11978_retract-and-unretract-in-a-travel
wawanbreton 576209a
Fix possibly uninitialized split position
wawanbreton 3ccf8b3
Apply clang-format
wawanbreton a3c56e1
Merge remote-tracking branch 'origin/main' into CURA-11978_retract-an…
wawanbreton 00f0cd3
Apply clang-format
wawanbreton fd181b8
Reduce retract/prime if there is not enough time to process during tr…
wawanbreton e02d0a4
Add feature type to distinguish (un)retracting moves
wawanbreton 7d215dd
Make retraction test more explicit
wawanbreton 6a49e9d
Apply clang-format
wawanbreton ba9a413
Merge branch 'main' into CURA-11978_retract-and-unretract-in-a-travel
HellAholic fd309cf
Fix unit tests
wawanbreton a1159f4
Fix build with emscripten
wawanbreton 2dc147c
Fix wrong travel position after extruder switch
wawanbreton 4537b6d
Apply keep_retracting_during_travel
wawanbreton 3723f72
Fix wrong time estimations regarding retraction during travel
wawanbreton a9e57d9
Fix case where the retract/prime ratio was incorrect
wawanbreton b83d9b1
Add missing new print feature types
wawanbreton 43bb4f8
Merge branch 'main' into CURA-11978_retract-and-unretract-in-a-travel
HellAholic d0a8857
Update Cura.proto
HellAholic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright (c) 2023 UltiMaker | ||
| // CuraEngine is released under the terms of the AGPLv3 or higher | ||
|
|
||
| #ifndef TRAVELANTIOOZING_H | ||
| #define TRAVELANTIOOZING_H | ||
|
|
||
| #include "geometry/Point2LL.h" | ||
| #include "settings/types/Ratio.h" | ||
|
|
||
| namespace cura | ||
| { | ||
|
|
||
| struct ZHopAntiOozing | ||
| { | ||
| double amount{ 0 }; //!< The absolute amount of retracted material (in mm) to be reached while the nozzle is moved up/down | ||
| Ratio ratio; //!< The ratio of the full z-hop move that contains a retract/prime | ||
| }; | ||
|
|
||
| struct TravelAntiOozing | ||
| { | ||
| double amount_while_still{ 0 }; //!< The absolute amount of retracted material (in mm) to be reached while the nozzle is still | ||
| ZHopAntiOozing z_hop; //!< The amount and ratio of retracted material to be processed during z-hop move | ||
| double amount_while_travel{ 0 }; //!< The absolute amount of retracted material (in mm) to be reached while the nozzle is traveling | ||
| Point2LL segment_split_position; //!< The intermediate position on the last/first segment that contains a retract/prime, where it should actually stop/start | ||
| std::vector<double> amount_by_segment; //!< For each intermediate segment containing a retraction/prime, this is the absolute amount to be reached at the end of the segment | ||
| }; | ||
|
|
||
| } // namespace cura | ||
|
|
||
| #endif /* TRAVELANTIOOZING_H */ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.